Fix crashes in ParametersAcceptorSelector #4467
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been marked as ready for review. |
ondrejmirtes
requested changes
Oct 23, 2025
| public function testBug13714(): void | ||
| { | ||
| $errors = $this->runAnalyse(__DIR__ . '/data/bug-13714.php'); | ||
| $this->assertCount(19, $errors); |
There was a problem hiding this comment.
What are the 19 errors? Can you produce code that makes PHPStan crash but once fixed, it produces no errors?
There was a problem hiding this comment.
no errors seems hard todo, but I reduced it to a minimum
|
Awesome, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes phpstan/phpstan#13714